APPSINTG-391: fix CVE-2026-59890 — upgrade setuptools to >=83.0.0 - #100
Merged
Conversation
Bumps setuptools from 82.0.1 to 84.0.0 to fix MANIFEST.in exclusion bypass via Unicode normalization collision (NFC/NFD) on macOS APFS/HFS+. Versions < 83.0.0 could silently include files the maintainer intended to exclude from a published sdist. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The integration tests are ordered and stateful (test_02 creates a collector whose ID is used by test_03 and test_04), so running them in parallel workers via pytest-xdist breaks state sharing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency minimum/version updates and accompanying release metadata changes are consistent and align with the stated security remediation and test stability goals.
Pull request overview
This PR updates the project’s build tooling and release metadata to remediate CVE-2026-59890 (GHSA-h35f-9h28-mq5c) by requiring a patched setuptools version, and adjusts test execution settings to avoid flaky parallel runs.
Changes:
- Raised
setuptoolsminimum version to>=83.0.0(and updated the lockfile to84.0.0) to address the CVE. - Bumped the project version to
0.2.1and added a corresponding changelog entry. - Removed
-n autofrompytestdefault options to run tests serially.
File summaries
| File | Description |
|---|---|
| VERSION | Bumps the package version to 0.2.1 for the security release. |
| pytest.ini | Removes parallel test execution flag to avoid ordering/state-related failures. |
| pyproject.toml | Updates build-system setuptools requirement to >=83.0.0. |
| Pipfile | Raises dev setuptools constraint to >=83.0.0. |
| Pipfile.lock | Updates locked setuptools to 84.0.0 with updated hashes/markers. |
| CHANGELOG.md | Adds 0.2.1 security entry documenting the setuptools upgrade and CVE. |
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sumoanema
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setuptoolsfrom82.0.1to84.0.0(constraint>=83.0.0) to fix CVE-2026-59890 / GHSA-h35f-9h28-mq5c — MANIFEST.in exclusion bypass via Unicode normalization collision (NFC/NFD) on macOS APFS/HFS+0.2.1and added CHANGELOG entry-n autofrompytest.inito fix parallel test failures (the integration tests are ordered and share state across test methods)Test plan
test_01_get_api_call,test_02_post_api_call,test_03_update_api_call,test_04_delete_api_call)