Open
Conversation
Collaborator
Collaborator
Collaborator
|
Hi @vfalconisumo , thank you for doing this! I wasn't sure how to test the changes, but this was Claude Code's advice. Code review notes on workflow changes Two issues in 1. Multiline commit messages will break # Current — breaks if commit message has multiple lines
echo "reason=$REASON" >> $GITHUB_OUTPUTFix: echo "reason<<EOF" >> $GITHUB_OUTPUT
echo "$REASON" >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT2. Commit messages with special characters will produce invalid JSON # Current — a commit message like: Fix bug in "auth" module
# produces: { "TRIGGER_SOURCE": "Fix bug in "auth" module" } ← invalid JSON
-d '{ "TRIGGER_SOURCE": "${{ steps.cause.outputs.reason }}" }'Fix using -d "$(jq -n --arg src "${{ steps.cause.outputs.reason }}" '{"TRIGGER_SOURCE": $src}')"Both issues stem from PR titles and commit messages being freeform user text that isn't sanitized before being embedded in structured formats (JSON, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request updates the production deployment workflow in two ways:
haythem/public-ipAction with an equivalent shell script. We're not sure of the how or the why, buthaythem/public-iphas been returning intermittent errors which have broken pipeline runs for a few weeks.Risk
I've tested the new scripts in a sandbox and am confident they work. However, if the changes do introduce workflow errors, publishing docs content will be impacted.
If the workflow fails as a result of these changes, revert this PR to restore the workflow.
Select the type of change
Ticket (if applicable)