Fix scroll jump when opening task subtasks - #9
Merged
Conversation
- Restore window.scrollY after gantt re-renders on desktop layouts where vertical scroll lives on the page, not inside .gscroll - Restore detail modal (.tbox) scroll when refreshing the same task after subtask edits (toggle done, change owner/size, etc.) Co-authored-by: Tanops <Tanops@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When expanding subtasks on the gantt timeline or interacting with subtasks in the task detail sheet, the page/modal would jump back to the top.
Root cause
.gscroll(which is horizontal-only on default desktop layouts). Re-renders after expanding subtasks restoredscrollTopon the wrong element.openDetail()rebuilt the modal DOM without saving/restoring.tboxscroll position, so edits to subtasks (toggle done, change owner, etc.) reset the modal to the top.Fix
window.scrollYalongside gantt scroll on everyrenderGantt()call..tboxscroll whenopenDetail()refreshes the same task (e.g. after subtask edits). Drilling into a different subtask still starts at the top of the new view.Testing
npm test— all 37 tests pass