Close detail sheet when clicking chart background - #11
Merged
Conversation
Let pointer events pass through the full-screen modal wrapper so clicks on the dimmed gantt/scrim dismiss the project, task, or subtask editor without requiring the close button. Co-authored-by: Tanops <Tanops@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the project/task/subtask detail sheet was open, only the ✕ button would close it. The chart behind the modal was visible but not clickable — the full-screen modal wrapper intercepted all pointer events.
Fix
pointer-events: noneon the open modal wrapper so clicks pass through to the chart/scrim behind it.pointer-events: autoon.tboxso the editor itself remains fully interactive.closeSheet()) now receives backdrop clicks on the dimmed chart area.Testing
npm test— all 37 tests pass