Skip to content

fix: Fixed library warnings#75

Open
Kinchul wants to merge 3 commits into
SuessLabs:developfrom
fiveco:vk/FixWarnings
Open

fix: Fixed library warnings#75
Kinchul wants to merge 3 commits into
SuessLabs:developfrom
fiveco:vk/FixWarnings

Conversation

@Kinchul
Copy link
Copy Markdown

@Kinchul Kinchul commented Apr 13, 2026

Title: Fixed library warnings

Summary

This fixes compiler warnings in the library after the recent D-Bus dependency update (and some legacy warnings). It does not change the code behavior, just makes it compilation cleaner.

What changed

  • disabled nullable analysis in the generated D-Bus bindings since the generator does not emit nullable annotations
  • removed the duplicated local CloseSafeHandle shim now that Tmds.DBus already provides that type
  • fixed nullable/lifecycle issues in the handwritten library wrappers
  • kept backward-compatible population of legacy DeviceProperties members while suppressing the obsolete-member usage locally

Disclosure

This was done with the help of AI.

@Kinchul Kinchul marked this pull request as ready for review April 13, 2026 15:19
@Kinchul
Copy link
Copy Markdown
Author

Kinchul commented May 20, 2026

FYI I rebased my changes on the most recent commit on the develop branch to ease any upcoming merge. I removed WaitForPropertyValueAsync from DeviceExtensions since it's now implemented in a more general way in WatchableExtensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants