Feature. Romanisation tool - #12760
Open
thando-ndlovu wants to merge 12 commits into
Open
Conversation
Files for romanisation logic added in `libse` as `Nikse.SubtitleEdit.Core.Romanize`. Japanese (Kana), Korean, and Russian are used to start. `IRomanizer` used as container to allow for easy updates
Simple dialog with by RomanizationView along with RomanizationViewModel added. Romanization tool added in Menu. Various accompanying edits to existing files.
Added the ability to merge lines into one upon romanisation. Added the ability to position romanised text in relation to original, as well as replace
Added - Merge lines heckbox for entire subtitle file - Position Dropdown for entire subtitle file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image below is one of the intended outcomes of a file processing.
Would be created with romanisation tool and ported into various styles by using existing tools (merge lines, merge two subtitles, edit subtitle appearance etc)
(1) Tools.Romanize
Standard romanization for subtitles
Would love feedback on what else is needed to effectively incorporate feature
Below is updated romanization tool section