Skip to content

Bind a passkey session to the contract and network it may commit to #390

Closed

Description

@karagozemin

Goal

Let a passkey commit a bid only to the contract id and network stored when the passkey session was created.

Why this is High

The passkey panel, the web config, and the SDK client can each be pointed at a different contract. A session opened against testnet must not sign a mainnet commit. The binding has to be checked at submit time.

Requirements

  • Record contract id, network passphrase, and account when the passkey session starts.
  • Refuse a commit when any of those differ from the current SDK client.
  • Surface a typed error in the panel instead of submitting.
  • Keep the secret seed out of the error and out of the demo trace.

Acceptance criteria

  • A matching session can commit in the fixture test.
  • A swapped contract id does not submit.
  • A swapped passphrase does not submit.
  • The error text does not contain the fixture seed.

Pointers

  • apps/web/src/components/PasskeyPanel.tsx
  • apps/web/src/passkey-config.ts
  • apps/web/src/lib/config.ts
  • packages/sdk/src/client.ts
  • packages/sdk/src/network.ts

Validation

  • Web config tests and an SDK network mismatch test

Drips

  • Drips Complexity: High
  • Expected Drips Points: 200
  • Add this issue from the Drips maintainer dashboard and set complexity to High.
  • Do not apply the Stellar Wave label on GitHub. That path defaults the issue to Trivial (100 points).

Activity

  1. added
    drips-candidateCandidate for a Drips Stellar Wave
    complexity: highExpected high implementation complexity
    area: webWeb application and React integration
    on Sep 29, 2026
  2. nazteeemba commented on Sep 29, 2026

    @nazteeemba
    Contributor

    @nazteeemba has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    Please assign me to this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @nazteeemba to this issue.

  3. salem-byt commented on Sep 29, 2026

    @salem-byt

    @salem-byt has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    Hello Maintainer, I can fix this issue.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @salem-byt to this issue.

  4. Viccodes11 commented on Sep 29, 2026

    @Viccodes11

    @Viccodes11 has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    Hi maintainer, I can work on this. I've gone through it, I can get it resolved

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Viccodes11 to this issue.

  5. drips-wave commented on Sep 29, 2026

    @drips-wave

    Congratulations, @nazteeemba! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.

    🧑‍💻 @nazteeemba: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  6. added a commit that references this issue on Oct 1, 2026
  7. grantfox-oss commented on Oct 1, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @nazteeemba's PR #454 was approved and merged by @karagozemin.

    🏆 @nazteeemba: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (751 total points). Track your full progress on GrantFox.

    👏 Great work, @nazteeemba! Keep contributing to Sub-Rosa-Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssue proposed for the Drips Stellar Wave programarea: sdkTypeScript SDKarea: webWeb application and React integrationcomplexity: highExpected high implementation complexitydrips-candidateCandidate for a Drips Stellar Wave

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions