Skip to content

chore(deps): upgrade gpui kit and checkout action - #312

Merged
StudentWeis merged 1 commit into
mainfrom
chore/upgrade-gpui-checkout
Oct 31, 2026
Merged

StudentWeis merged 1 commit into
mainfrom
chore/upgrade-gpui-checkout

Conversation

@StudentWeis

Copy link
Copy Markdown
Owner

Summary

Upgrade GPUI Kit to 0.8.1 and use checkout v7 in the generated release workflow. Preserve the existing renderer and feature set, and adapt shortcut handling to the updated GPUI runtime-host APIs.

Linked Issue

Closes #311

Changes

  • Upgrade normal/dev GPUI Kit dependencies and the associated lockfile graph, including gpui-pre 0.3.10; leave unrelated direct dependencies unchanged.
  • Load dynamic shortcuts with the application context, parse/format them with the runtime host OS, and use static default key strings. Update the deprecated scroll handler.
  • Retain existing shortcut validation and editor UI coverage; add macOS/Windows/Linux host cases for secondary-modifier normalization and conflict detection.
  • Update the Ropy GPUI adapter to upstream commit 99576db58ec8103417c41a092e891b4022d24e7e. Both official skill directories match v0.8.1 exactly (their content is unchanged from v0.8.0).
  • Configure the cargo-dist checkout override in dist-workspace.toml and regenerate release.yml rather than editing generated output by hand.

Testing

  • scripts/precheck.sh passes locally
  • New / updated tests cover the change
  • Full precheck passed on Linux: 83 script tests, Clippy, all workspace targets/features, isolated D-Bus tray regression, and documentation with warnings denied. Selected the installed RTK binary through PATH because the default mise shim had no version configured.
  • dist generate --mode ci --check passed.
  • diff -qr against both v0.8.1 official skill directories passed.
  • Markdown structure/link checks for the three adapter documents and git diff --check passed.
  • The initial compile after the dependency update exposed the old keybinding API calls; the migrated implementation passes the full gate.
  • Native macOS/Windows builds and GUI acceptance have not been run locally. Host-parameterized tests are not native desktop acceptance; cross-platform CI and native clipboard/IME/focus smoke tests remain separate validation.

Self-Check

  • PR title follows Conventional Commits
  • No hardcoded user-facing strings — i18n keys added to all locale files
  • Errors defined with thiserror (no manual impl Display/Error)
  • No unrelated changes mixed in

@StudentWeis
StudentWeis merged commit 2e4393d into main Oct 31, 2026
12 checks passed
@StudentWeis
StudentWeis deleted the chore/upgrade-gpui-checkout branch October 31, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: upgrade gpui kit and checkout action

1 participant