Repository navigation
fix(app): resolve hotkey, file uri and updater audit findings - #305
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve newer shortcut drafts when asynchronous registration finishes, reject unsupported file URI authorities, and capture update-helper failures on stderr. History rows now borrow records and prepare bounded previews only when needed.
Linked Issue
Closes #304
Changes
localhost, reject unsupported hosts and incomplete URIs, and preserve literal filesystem whitespace and percent characters.Testing
scripts/precheck.sh --checkpasses locally: 794 Rust tests passed, 3 existing tests ignored; 83 Python tests passed; Clippy, formatting, resource checks, core dependency boundaries, private D-Bus tray test and rustdoc passed.Validation ran on Linux using headless GPUI and native helper subprocesses. Native macOS, Windows and Wayland desktop end-to-end tests were not run.
Self-Check
thiserror(no manualimpl Display/Error) — no new error types