Skip to content

fix(app): preserve selection and reconcile automatic startup - #301

Merged
StudentWeis merged 1 commit into
mainfrom
fix/audit-selection-autostart
Oct 22, 2026
Merged

StudentWeis merged 1 commit into
mainfrom
fix/audit-selection-autostart

Conversation

@StudentWeis

@StudentWeis StudentWeis commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Summary

Filtering could move selection to a different surviving record, and automatic startup could retain an invalid directory, command, or executable target. Preserve selected record identity and reconcile startup registrations to the current installation, while sharing the native popup activation path across entrypoints.

Linked Issue

Closes #300

Changes

  • Preserve selection across content, favorites, and query filters; resolve record IDs again after repository snapshots and remove unused filter-plan lengths.
  • Write Linux autostart entries under the XDG configuration directory, encode desktop-entry Exec paths, and atomically repair stale entries without touching other configuration directories.
  • Compare the Windows current-user startup target with the current executable and quote the command path; retain the existing macOS login-item backend.
  • Share popup geometry and native focus activation for tray panels, global shortcuts, and CLI activation.
  • Install the cargo-dist version declared in dist-workspace.toml and add an isolated setup-command regression.
  • Correct Wayland keycode-conflict documentation and remove the command that cleared unrelated macOS extended attributes.

Testing

  • scripts/precheck.sh passes locally: 83 Python tests, 750 Rust tests, Clippy, dependency-boundary checks, resource checks, formatting, and rustdoc.
  • New / updated tests cover the change: filter interaction and copy payloads, snapshot index reuse, autostart configuration isolation and path repair, path encoding, write failure, and configured setup-tool selection.
  • Markdown checks pass for all changed documentation.
  • CI for commit 284e70f passes: macOS and Windows builds/tests, Linux Clippy/tests/docs, core tests, lightweight checks, and the aggregate precheck. The release plan also passes.
  • Windows/Linux native login and desktop focus behavior have not been exercised locally; CI builds and unit tests do not certify native desktop behavior.
  • The existing block 0.1.6 future-incompatibility warning remains in the GPUI dependency graph. Upstream has no compatible fixed release; this PR does not vendor or patch that dependency.

Self-Check

  • PR title follows Conventional Commits
  • No hardcoded user-facing strings — i18n keys added to all locale files where needed
  • Errors defined with thiserror (no manual impl Display/Error)
  • No unrelated changes mixed in

@StudentWeis
StudentWeis merged commit 32079fa into main Oct 22, 2026
12 checks passed
@StudentWeis
StudentWeis deleted the fix/audit-selection-autostart branch October 22, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: preserve selection and reconcile automatic startup

1 participant