Skip to content

ci(devnet): put the two newest coverage classes in the default filter - #166

Closed
Platonenkov wants to merge 1 commit into
devfrom
claude/devnet-coverage-filter-691f22
Closed

ci(devnet): put the two newest coverage classes in the default filter#166
Platonenkov wants to merge 1 commit into
devfrom
claude/devnet-coverage-filter-691f22

Conversation

@Platonenkov

@Platonenkov Platonenkov commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

TestIXChainAttestation and TestILoanMultisig were written after devnet-coverage.yml and never added to its default filter. Between them they are the only traffic for both attestation transaction types, XChainClaim, and LoanSet.CounterpartySignature.Signers, so a run left on the defaults covered none of that.

The comment above the filter now says to keep it in step, and names what was missed.

Verified by dispatching the workflow with the corrected filter before this change landed: run 33823118083, 101 tests, 92 passed, 9 skipped because MPTokensV2 is not enabled on devnet, none failed. That run was also the first time this workflow executed in Actions at all: workflow_dispatch is read from the default branch, so it only became reachable once #165 merged.

Summary by CodeRabbit

  • Documentation
    • Updated development network coverage guidance to document faucet availability, third-party network requirements, and manual-run constraints.
    • Clarified the coverage classes required for successful validation.
  • Tests
    • Expanded the default development network test selection to include multisignature loan and chain attestation coverage.

TestIXChainAttestation and TestILoanMultisig were written after this workflow
and never added to it. Between them they are the only traffic for both
attestation transaction types, XChainClaim, and
LoanSet.CounterpartySignature.Signers, so a default run covered none of that.

Verified by dispatching with the corrected filter: 101 tests, 92 passed, 9
skipped for MPTokensV2 being absent from devnet, none failed.
@Platonenkov

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 7a88df9e-459c-4308-b6cb-c741d969fda3

📥 Commits

Reviewing files that changed from the base of the PR and between d0f9ba1 and 19b28cf.

📒 Files selected for processing (1)
  • .github/workflows/devnet-coverage.yml

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The devnet coverage workflow now documents execution constraints and runs TestIXChainAttestation and TestILoanMultisig by default.

Changes

Devnet coverage workflow

Layer / File(s) Summary
Coverage documentation and test selection
.github/workflows/devnet-coverage.yml
The workflow documents faucet, third-party network, and manual-run constraints. The default test filter includes TestIXChainAttestation and TestILoanMultisig.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 19b28

The workflow now includes attestation and loan multisig coverage in its default devnet test filter. The supplied successful run and review evidence indicate no remaining merge-readiness risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding the two newest coverage classes to the default devnet filter.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/devnet-coverage-filter-691f22

Comment @coderabbitai help to get the list of available commands.

@Platonenkov

Copy link
Copy Markdown
Collaborator Author

Superseded by #167. The two filter entries from this branch are merged into that one, together with TestISponsoredVaultLoan, which arrives with it. Keeping them apart meant whichever landed second would leave the other's classes out of the default run of devnet-coverage.yml, and the follow-up to fix that had to be remembered by hand.

@Platonenkov Platonenkov closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant