Repository navigation
ci: stamp OCI labels on the beta image - #1121
Merged
Merged
Conversation
deploy-beta.yml and the Docker workflow both publish beta-omnibus on a push to beta, and only the Docker workflow attached OCI labels. Whichever finished last owned the tag, so the image could ship without the revision label that deployment checks read: on 2026-11-05 the beta-omnibus pulled for 8500fbc had an empty org.opencontainers.image.revision. This applies the #1052 fix for develop to the beta workflow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XyPthdc2JY99hPmTJUYPBu
Owner
Author
|
Independent read-only review at
CI at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-beta.ymlnow stamps the same OCI labels as the Docker workflow, sobetaandbeta-omnibusalways carryorg.opencontainers.image.revision. This applies the #1052 fix fordevelopto the beta workflow.Type of Change
Related Issues
Same race as #1052, for the beta channel. No issue filed.
Changes Made
docker/metadata-action@v6step (id: meta) before the beta build, configured likedeploy-testing.yml.labels: ${{ steps.meta.outputs.labels }}todocker/build-push-action.Testing
actionlint .github/workflows/deploy-beta.ymlpasses, and the file parses as YAML. The workflow runs only on a push tobeta. This PR changes no tag names, platforms or cache scopes.Evidence for the problem: on 2026-11-05, Zeus pulled
beta-omnibusafter #1114 merged (8500fbc3).docker image inspectshowed an emptyorg.opencontainers.image.revision, although both Publish Beta Image and Docker succeeded for that commit.Additional Notes
Review: required (a workflow change that takes effect on merge with no separate deploy step).
deploy-beta.ymlis identical ondevelop,masterandbeta. The fix reaches the beta workflow only after the next promotion tomasterand themasterintobetasync.