Skip to content

ci: stamp OCI labels on the beta image - #1121

Merged
Starosdev merged 1 commit into
developfrom
fix/beta-image-oci-labels
Nov 5, 2026
Merged

Starosdev merged 1 commit into
developfrom
fix/beta-image-oci-labels

Conversation

@Starosdev

Copy link
Copy Markdown
Owner

Summary

deploy-beta.yml now stamps the same OCI labels as the Docker workflow, so beta and beta-omnibus always carry org.opencontainers.image.revision. This applies the #1052 fix for develop to the beta workflow.

Type of Change

  • CI/CD or infrastructure change

Related Issues

Same race as #1052, for the beta channel. No issue filed.

Changes Made

  • Add a docker/metadata-action@v6 step (id: meta) before the beta build, configured like deploy-testing.yml.
  • Pass labels: ${{ steps.meta.outputs.labels }} to docker/build-push-action.

Testing

  • I have tested this locally
  • I have added/updated tests that prove my fix/feature works
  • All existing tests pass

actionlint .github/workflows/deploy-beta.yml passes, and the file parses as YAML. The workflow runs only on a push to beta. This PR changes no tag names, platforms or cache scopes.

Evidence for the problem: on 2026-11-05, Zeus pulled beta-omnibus after #1114 merged (8500fbc3). docker image inspect showed an empty org.opencontainers.image.revision, although both Publish Beta Image and Docker succeeded for that commit.

Additional Notes

Review: required (a workflow change that takes effect on merge with no separate deploy step).

deploy-beta.yml is identical on develop, master and beta. The fix reaches the beta workflow only after the next promotion to master and the master into beta sync.

deploy-beta.yml and the Docker workflow both publish beta-omnibus on a push
to beta, and only the Docker workflow attached OCI labels. Whichever finished
last owned the tag, so the image could ship without the revision label that
deployment checks read: on 2026-11-05 the beta-omnibus pulled for 8500fbc
had an empty org.opencontainers.image.revision. This applies the #1052 fix
for develop to the beta workflow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XyPthdc2JY99hPmTJUYPBu
@Starosdev

Copy link
Copy Markdown
Owner Author

Independent read-only review at 42f9adbe, recorded before merge: SHIP.

  • meta is defined after image_name and before the build step uses it; the pushed tags (:beta, :beta-omnibus) are unchanged, since docker/build-push-action keeps its explicit tags and takes only the labels.
  • Action pins match docker-build.yaml (metadata-action@v6, build-push-action@v7). Both workflows derive org.opencontainers.image.revision from the same github.sha, so they no longer race on it. created and version can still differ between the two, as they do for develop after ci: stamp OCI labels on the testing image #1052.
  • docker-build.yaml also publishes plain :beta for the omnibus image, so the fix covers both tags.

CI at 42f9adbe: 17 pass, 1 skipped. The fix reaches the beta workflow after the next promotion to master and the master into beta sync.

@Starosdev
Starosdev merged commit f79c2d7 into develop Nov 5, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant