Conversation
|
Removed |
LouisLotter
left a comment
LouisLotter
left a comment
There was a problem hiding this comment.
Reviewed at da4accf0 as part of the logs set-A review, with an independent Opus 5.5/high source check. The new transport package tests pass on Linux; the complete macOS suite fails in the new system-trust test below. No Linux runtime TLS defect was found.
| caFile := filepath.Join(t.TempDir(), "receiver-ca.pem") | ||
| require.NoError(t, os.WriteFile(caFile, ca, 0600)) | ||
| command := exec.Command(os.Args[0], "-test.run=^TestTLSOptionsSystemTrustHelper$") | ||
| command.Env = append(os.Environ(), "SSL_CERT_FILE="+caFile, "RECEIVER_TEST_URL="+server.URL) |
There was a problem hiding this comment.
[P2] The system-trust test is not portable to macOS. Go's Darwin verifier uses platform trust and does not load the synthetic CA from SSL_CERT_FILE, so go test ./... fails here with x509: certificate signed by unknown authority. Reproduced on macOS; the OpenAPI-client package passes on Linux. The repository explicitly provides Darwin development shells. Please gate just this environment-based system-trust assertion to supported platforms, or use a platform-appropriate test, while keeping the ordinary untrusted/insecure-mode TLS cases portable.
There was a problem hiding this comment.
Fixed in 6806615: only the SSL_CERT_FILE system-trust assertion is Linux-only; untrusted and insecure-mode cases remain portable. Native macOS confirmation is still welcome.
|
Fixed the P2 portability regression in |
2 participants
Adds
NewOpenAPIClientWithOptionswith owned transport, rotating authentication, bounded requests, explicit proxy, system certificate trust and redirect rejection. The existing constructor retains its authentication behavior.Tracking: https://github.com/StackVista/stackstate/issues/587