fix(suse-observability): fix freshness and concurrency monitors misfiring - #26
Merged
Merged
Conversation
…iring The freshness monitor compared the instantaneous age of the newest sample against 30s. That age climbs to the scrape interval between every scrape, so healthy namespaces crossed the threshold each cycle and flapped. Take the minimum age over a one-minute window instead, which removes the scrape sawtooth and leaves the scrape-to-queryable delay. The aggregation has to sit outside the subquery; the metric backend rejects an aggregation inside it. Scope both concurrency monitors to VictoriaMetrics. vmagent exposes the same vm_concurrent_insert metrics for its own incoming writes, and on small deployments its capacity of 2 put it into DEVIATING on normal load.
rb3ckers
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two monitors from #25 that misfire on healthy systems.
Test-deployed to nightly: all three monitors CLEAR, matching only VictoriaMetrics pods including HA instance 1.
Correction to #25: its note that the counter-based monitors produce no check states came from a parsing error on my side. All six evaluate normally.
Refs https://github.com/StackVista/helm-charts-internal/issues/230