Skip to content

fix: improve stock card hover contrast - #232

Open
Ambu-2005 wants to merge 1 commit into
SrigadaAkshayKumar:mainfrom
Ambu-2005:fix/dark-mode-card-hover
Open

Ambu-2005 wants to merge 1 commit into
SrigadaAkshayKumar:mainfrom
Ambu-2005:fix/dark-mode-card-hover

Conversation

@Ambu-2005

Copy link
Copy Markdown

Pull Request for Stock Analyzer

Thank you for contributing to the Stock Analyzer open-source project!

Issue Title

[BUG] Card text becomes unreadable on hover in dark mode

Contributor Details

Closes

Closes #230

Describe Your Changes

  • Improved stock card text contrast when hovering in dark mode.
  • Ensured stock symbols and company names remain clearly readable on hover.
  • Used the existing --color-text theme variable for consistent text colors.

Screenshots

Dark mode stock cards were tested locally. The stock symbol and company name are clearly readable when hovering over a card.

what are the files you have changed

  • src/components/StockList.module.css

How Has This Been Tested?

  • Ran the Stock Analyzer locally using npm start.
  • Tested the stock cards in dark mode.
  • Hovered over stock cards including SBIN.NS.
  • Verified that the stock symbol and company name remain readable on hover.
  • Confirmed the changes only affect the intended stock card hover styling.

Type of Change

  • Bug fix (fixes an existing issue)
  • New feature (adds new functionality)
  • Code style update (formatting, refactoring)
  • Breaking change (may affect existing features)
  • Documentation update

Checklist

  • My code follows the project’s guidelines and best practices.
  • I have performed a self-review of my code.
  • I have added meaningful comments where necessary.
  • I have updated documentation wherever applicable.
  • My changes do not generate any new warnings or errors.
  • I have included screenshots, graphs, or test logs (if applicable).
  • Any dependent changes have been merged and documented.

Thank you for helping improve Stock Analyzer!

@github-actions

Copy link
Copy Markdown

Thanks for opening this Pull Request! A maintainer will review it shortly. Please make sure you've followed all contribution guidelines.

Join our Discord Community for discussions, questions, and real-time collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Card text becomes unreadable on hover in dark mode

1 participant