Improve publishing#169
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8f4d5bff1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| val content = file.readText() | ||
| val pluginId = Regex.escape(id) | ||
| // Regex to match: id("pluginId") version "version-number" | ||
| val regex = """id\("$pluginId"\)\s+version\s+"([^"]+)"""".toRegex() |
There was a problem hiding this comment.
The pattern used to match id("…") version "…" is missing the trailing quote after the captured version, so replacement leaves the original closing quote in place and writes invalid Kotlin DSL like version "2.0.0"". This will corrupt every updated build.gradle.kts file when this task runs for non-Kotlin plugin IDs.
Useful? React with 👍 / 👎.
2 participants
This PR applies latest
configthus improving the code of publishing. It was hoped that the size of fat JARs for IntelliJ Platform would be reduced. But it turned out that there were no duplications of.classfiles which we observed in CoreJvm Compiler artifacts. Still, now the build tunes theShadowJartask to avoid the duplication. So, we're on the safe side.