(when) option compiler#190
Open
alexander-yevsyukov wants to merge 37 commits intomasterfrom
Open
Conversation
Also: * Eliminate duplicating test dependencies.
Also: * Move `WHEN` constant under `WhenOption`.
Also: * Consolidate `validation-tests`.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
============================================
- Coverage 92.75% 84.27% -8.49%
Complexity 304 304
============================================
Files 57 60 +3
Lines 980 1081 +101
Branches 31 45 +14
============================================
+ Hits 909 911 +2
- Misses 61 160 +99
Partials 10 10 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9cad8f439
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
armiol
requested changes
Apr 28, 2026
Contributor
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov LGTM with a couple of minor comments.
| import org.junit.jupiter.api.Test | ||
| import io.spine.time.LocalDateTime as SpineTimeLocalDateTime | ||
|
|
||
| @DisplayName("If used with Spine `Temporal`, `(when)` constrain should") |
| @@ -0,0 +1,69 @@ | |||
| /* | |||
| * Copyright 2024, TeamDev. All rights reserved. | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings compilation of the
(when)validation option which was previously a part of the Validation library.Changes in details
validationmodules was added with the code of the(when)option compilation.TimeGradlePluginnow addsio.spine.tools:time-validationartifact to the Compiler's user classpath configuration. In tern,JavaValidationPluginpicks up the code generation viaValidationOptionservice loader API.testssubproject was introduced for running integration tests.time-validationartifact was adjusted to have no dependencies. They are going to be available at the classpath ofJavaValidationPlugin.Other notable changes
configwas applied.