Skip to content

Fix license.distribution property of a POM#140

Merged
alexander-yevsyukov merged 4 commits intomasterfrom
fix-distribution-property
Apr 23, 2026
Merged

Fix license.distribution property of a POM#140
alexander-yevsyukov merged 4 commits intomasterfrom
fix-distribution-property

Conversation

@alexander-yevsyukov
Copy link
Copy Markdown
Contributor

This PR updates the PublicationHandler.kt fixing the value of the POM's license.distrubution property. According to Maven's API, it can be either "repo" or "manual". Putting URL of a license into this field is an error.

Later this change will be propagated to config.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7e46a5330

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +162 to +164
// This is unlikely case of `artifactId` being set to something unrelated.
// We overwrite it with our calculated ID.
project.artifactId
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep non-default publication artifact IDs distinct

When copyProjectAttributes() is used for custom publications (see CustomPublicationHandler.handlePublications), this new else branch collapses any publication whose artifactId does not start with project.name to the same project.artifactId. In modules that define multiple custom MavenPublications with explicit artifact IDs, that produces duplicate coordinates and publication clashes. The previous logic preserved distinct IDs (by carrying through the existing suffix), so this is a regression for custom publishing scenarios.

Useful? React with 👍 / 👎.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.16%. Comparing base (d4f09c8) to head (f7e46a5).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #140   +/-   ##
=========================================
  Coverage     14.16%   14.16%           
  Complexity      119      119           
=========================================
  Files           102      102           
  Lines          2443     2443           
  Branches        381      381           
=========================================
  Hits            346      346           
  Misses         2065     2065           
  Partials         32       32           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexander-yevsyukov alexander-yevsyukov merged commit badfaa9 into master Apr 23, 2026
7 checks passed
@alexander-yevsyukov alexander-yevsyukov deleted the fix-distribution-property branch April 23, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants