Improve the display of missing files#15
Open
Vladyslav-Kuksiuk wants to merge 2 commits intomasterfrom
Open
Conversation
Collaborator
dmytro-kashcheiev
left a comment
dmytro-kashcheiev
left a comment
There was a problem hiding this comment.
@Vladyslav-Kuksiuk LGTM with few comments to check before merge.
Comment on lines
+202
to
+204
| if err != nil { | ||
| panic(err) | ||
| } |
Collaborator
There was a problem hiding this comment.
The method by itself is a helper for logging, maybe it's not a best idea to panic if we can't formate logs correctly.
Comment on lines
+215
to
+217
| if err != nil { | ||
| panic(err) | ||
| } |
| return "", err | ||
| } | ||
| if originalCodePath == "" { | ||
| return fmt.Sprintf("%s", f.CodePath), nil |
Collaborator
There was a problem hiding this comment.
Is this somekind of a GO typing-trick? to print as %s this looks redundant
| return fmt.Sprintf("%s (%s)", f.CodePath, originalCodePath), nil | ||
| } | ||
|
|
||
| return fmt.Sprintf("%s", originalCodePath), nil |
dmytro-kashcheiev
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves displaying of paths, when file or fragment wasn't found.
Resolves this issue.
Possible errors: