Repository navigation
Don't follow symlinks when storing extractor paths - #4812
Merged
Merged
Conversation
alejoe91
approved these changes
Oct 2, 2026
Member
I think this is an issue only for the testing suite. Using locked annexed files in containers is not a use case I would take into consideration |
Contributor
Author
|
Yes, actually, it is a problem that requires 1) simlinks to another mounts (which I use) but also 2) renaming (which only git-annex does). I think this fix here is probably enough until we get a user case of it breaking beyond it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the solution for the failing tests on #4809 @alejoe91.
As mentioned, the reason the tests fail there is that with the recent changes on gin the annexed files are stored locked, as symlinks, and the
resolve()on the extractor kwargs follows them. So the Intan path goes from a name likeintan/intan_fpc_test_231117_052630/info.rhdto a name like.git/annex/objects/vf/J8/MD5E-s8082--faf8e5811c5e68da6c2fec030f6bb0f9.rhd/MD5E-s8082--faf8e5811c5e68da6c2fec030f6bb0f9.rhd. After unpickling neo no longer sees a file namedinfo.rhdso it doesn't look for theamplifier.datandtime.datfiles next to it and the recording comes back with 0 samples (NeuroNexus has the same problem with its_data.xdatfile).The solution is to use
absolute()instead ofresolve()which is what most of the extractors already do. This PR does that for the 12 places that usedresolve().I think that relative dumps and containers have the same problem but solving them needs more than
absolute()but this will have to wait. I will open an issue when I have some time.