Repository navigation

FIR phase-shift + extract `apply_raised_cosine_taper` from `get_chunk_with_margin` - #4563

Merged

alejoe91 merged 31 commits into

SpikeInterface:mainfrom

galenlynch:perf/phase-shift-fir

Nov 9, 2026

Merged

FIR phase-shift + extract `apply_raised_cosine_taper` from `get_chunk_with_margin`#4563
alejoe91 merged 31 commits into
SpikeInterface:mainfrom
galenlynch:perf/phase-shift-fir

Commits on May 9, 2026
- perf: FIR phase-shift alternative + apply_raised_cosine_taper extract
  
  galenlynch
  and
  claude
  committed
  9328356
- [pre-commit.ci] auto fixes from pre-commit.com hooks
  
  pre-commit-ci[bot]
  authored and
  galenlynch
  committed
  301355a
Commits on May 14, 2026
- fix(phase_shift): normalize FIR kernels to unity DC gain
  
  galenlynch
  and
  claude
  committed
  883489b
- perf(phase_shift): default FIR tap count 32 → 16
  
  galenlynch
  and
  claude
  committed
  7ed065e
Commits on May 15, 2026
- docs(phase_shift): document FIR's implicit lowpass and bandwidth tradeoff
  
  galenlynch
  and
  claude
  committed
  7cf5748
Commits on Jun 22, 2026
- fix: solve conflicts
  alejoe91
  committed
  08fdfb6
Commits on Oct 21, 2026
- perf: FIR phase-shift alternative + apply_raised_cosine_taper extract
  
  galenlynch
  and
  claude
  committed
  7fc1b7f
- [pre-commit.ci] auto fixes from pre-commit.com hooks
  
  pre-commit-ci[bot]
  authored and
  galenlynch
  committed
  82812a8
- fix(phase_shift): normalize FIR kernels to unity DC gain
  
  galenlynch
  and
  claude
  committed
  39a82d3
- perf(phase_shift): default FIR tap count 32 → 16
  
  galenlynch
  and
  claude
  committed
  aceb11a
- docs(phase_shift): document FIR's implicit lowpass and bandwidth tradeoff
  
  galenlynch
  and
  claude
  committed
  0f019f8
- feat: numpy fallback for FIR phase shift without numba
  galenlynch
  committed
  9e5a3a9
- fix: run the FIR phase-shift kernels single-threaded
  galenlynch
  committed
  c847a9f
- refactor: drop output_dtype and build FIR phase-shift taps in fir_filter's order
  galenlynch
  committed
  b9969c1
- chore: remove the phase-shift benchmark script
  galenlynch
  committed
  8444ca1
- docs: drop benchmark numbers from the phase_shift docstrings
  galenlynch
  committed
  3bc83b8
- docs: rewrite the phase_shift and taper docstrings for users
  galenlynch
  committed
  9e18169
- refactor: separate taper cleanup from FIR phase shifting
  galenlynch
  committed
  c3b2a90
Commits on Oct 26, 2026
- fix: use importlib instead of try-except
  alejoe91
  committed
  345796e
- fix: conflicts
  alejoe91
  committed
  97a1f73
- Merge branch 'main' into perf/phase-shift-fir
  alejoe91
  authored
  65ff527
- fix: HAVE_NUMBA in tests
  alejoe91
  committed
  e6ddf54
- Merge branch 'perf/phase-shift-fir' of github.com:galenlynch/spikeinterface into perf/phase-shift-fir
  alejoe91
  committed
  6327538
- fix: remove compute_dtype
  alejoe91
  committed
  ed7b4ca
- fix: temporarily copy traces in apply_raised_cosine_taper
  alejoe91
  committed
  c3c7551
- fix: restore the taper split lost in a merge
  galenlynch
  committed
  4a9dc5d
Commits on Oct 29, 2026
- Merge branch 'main' into perf/phase-shift-fir
  h-mayorquin
  authored
  aea7bfe
Commits on Oct 30, 2026
- fix: conflicts with 4887
  alejoe91
  committed
  e009b8d
Commits on Nov 3, 2026
- fix: address review on the FIR phase shift
  galenlynch
  committed
  c19012d
- feat: widen the FIR window and scale its beta with n_taps
  galenlynch
  committed
  ea7ef8e
Commits on Nov 9, 2026
- Merge branch 'main' into perf/phase-shift-fir
  alejoe91
  authored
  af179cb

Commits

Commits on May 9, 2026

Commits on May 14, 2026

Commits on May 15, 2026

Commits on Jun 22, 2026

Commits on Oct 21, 2026

Commits on Oct 26, 2026

Commits on Oct 29, 2026

Commits on Oct 30, 2026

Commits on Nov 3, 2026

Commits on Nov 9, 2026