Fix unit visibility change not propagating to other views#264
Merged
chrishalcrow merged 1 commit intoSpikeInterface:mainfrom Apr 15, 2026
Merged
Conversation
`get_visible_unit_ids()` returned a direct reference to the internal `_visible_unit_ids` list. Callers that snapshot the list before and after `set_unit_visibility()` to detect changes were comparing the same mutated object, so the comparison always found no difference and never triggered `notify_unit_visibility_changed()`. Return a copy instead so before/after comparisons work correctly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alejoe91
approved these changes
Apr 13, 2026
4 tasks
Member
|
Thanks @xiao-1011 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_visible_unit_ids()returned a direct reference to the internal_visible_unit_idslistset_unit_visibility()to detect changes were comparing the same mutated object, so the comparison always found no differencenotify_unit_visibility_changed()from firing, causing other widgets (waveforms, ISI, correlograms, etc.) to not refresh when toggling unit visibility in the unit listlist(self._visible_unit_ids)instead of the raw referenceTest plan
🤖 Generated with Claude Code