Skip to content

fix: set publish.yml CommonSource build property to stable BED-7878 #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lrfalslev wants to merge 1 commit into from
Closed

fix: set publish.yml CommonSource build property to stable BED-7878 #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
name: Build (${{ matrix.release.type }})

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v6

- name: Setup .NET
uses: actions/setup-dotnet@v5
Expand All @@ -36,7 +36,7 @@ jobs:
- name: Build
run: |
VERSION=${{ github.ref_name }}
dotnet build -c ${{ matrix.release.type }} -p:Version=${VERSION:1} -p:CommonLibSource=Release
dotnet build -c ${{ matrix.release.type }} -p:Version=${VERSION:1} -p:CommonLibSource=Stable
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Use the correct MSBuild property name (CommonSource)

Line 39 sets CommonLibSource, but package version selection in Sharphound.csproj is based on CommonSource (Sharphound.csproj:17-40). As written, this can leave the build on the default dev path instead of stable.

Proposed fix 
-          dotnet build -c ${{ matrix.release.type }} -p:Version=${VERSION:1} -p:CommonLibSource=Stable
+          dotnet build -c ${{ matrix.release.type }} -p:Version=${VERSION:1} -p:CommonSource=Stable
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
dotnet build -c ${{ matrix.release.type }} -p:Version=${VERSION:1} -p:CommonLibSource=Stable
dotnet build -c ${{ matrix.release.type }} -p:Version=${VERSION:1} -p:CommonSource=Stable
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/publish.yml at line 39, The CI uses the wrong MSBuild
property name: update the dotnet build invocation that sets CommonLibSource to
instead set CommonSource so the package selection in Sharphound.csproj (which
checks CommonSource) receives the intended value; locate the dotnet build
command (the line with "dotnet build -c ${{ matrix.release.type }}
-p:Version=${VERSION:1}") and replace the -p:CommonLibSource=... with
-p:CommonSource=... so the stable/dev selection works as expected.


- name: Zip
run: 7z a -tzip -mx9 SharpHound_${{ github.ref_name }}${{ matrix.release.suffix }}_windows_x86.zip $PWD/bin/${{ matrix.release.type }}/net472/*
Expand Down
Loading