Open
Conversation
12 tasks
yhmtsai
changed the title
yhmtsai
commented
Apr 10, 2026
Comment on lines
+76
to
+77
| template <typename matrix_opt, typename Conjugate = std::false_type, | ||
| typename Transpose = std::false_type, |
Contributor
Author
There was a problem hiding this comment.
I was using none, conj, trans specific type in previous commit.
The current one use std::false_type for none and std::true_type for conj and trans.
yhmtsai
commented
Apr 10, 2026
| typename Transpose = std::false_type, | ||
| diag::diag Diagonal = diag::explicit_diag, | ||
| uplo::uplo UpLo = uplo::full> | ||
| class general : public spblas::view_base { |
Contributor
Author
There was a problem hiding this comment.
other good name for that?
fixed_order, vendor, legacy, blas-like?
Contributor
There was a problem hiding this comment.
I like something like "legacy_pattern" or "blas_pattern"
yhmtsai
force-pushed
the
dev/yhmtsai/tag_view
branch
from
4dd3f0c to
3a29cbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Traditional vendor APIs require a specific ordering to describe how operations are applied. In std::linalg, the triangular solve descriptor is applied on top of op(A), which is not fully intuitive.
To improve usability, we choose not to expose the triangular descriptor as an explicit argument. Instead, users can define the operation directly in terms of the mathematical equation, without needing to translate it into the API’s required ordering.
This PR bridges the gap between the user-defined expression and the ordering expected by the underlying API.
Details:
Merge Checklist: