fix: validation of url fields#359
Open
jakub206 wants to merge 4 commits into
Open
Conversation
|
Looks like you did not link an issue to this PR. If this PR completes a task, consider linking it. |
michalges
previously requested changes
May 13, 2026
Member
michalges
left a comment
michalges
left a comment
There was a problem hiding this comment.
można to zrobić trochę prościej, bezpośrenio używając z.string().startsWith()
https://zod.dev/api?id=strings#strings
michalges
requested changes
May 21, 2026
| .string() | ||
| .trim() | ||
| .url(FORM_ERROR_MESSAGES.INVALID_URL) | ||
| .startsWith("http://", { |
| FORM_ERROR_MESSAGES.INVALID_URL, | ||
| ); | ||
| ).startsWith("http://", { | ||
| message: FORM_ERROR_MESSAGES.INVALID_URL, |
Member
There was a problem hiding this comment.
ten błąd niewiele mówi użytkownikowi, może dodaj nowy w stylu "Adres URL powinien zaczynać się od https://"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed url validation