Update sn-bt-setup-peripheral.py#6
Conversation
|
Looking reasonable to me (although I cannot really judge the Python code itself). I would ask if you could capture some of the documentation on the supported environment variables into the package README file? We could use that info to perhaps tweak the systemd service to read in an optional environment file. |
|
Looking good with the README and Makefile updates, thanks. Other packages make it super easy for users to define service environment variable files in the For example we could tweak the logging then by creating that file with |
msqr
left a comment
There was a problem hiding this comment.
These changes look good. If you'd like them merged, you could drop the Draft status and let me know.
Updates the
sn-bt-setup-peripheral.pyafter renewed testing for Bluetooth connectivity.This presents some breaking changes:
TXcharacteristic is now notify instead of read.\x07is kept, but both\x26and\x00have been removed.\x18has been added for session tear down, server pull down, OSError, etc.Some extra environment variables are also read for debugging at the moment, but could be wired in the future for better observability in the node if required.
I've tried to rearrange the format of the file a bit to also keep it in style with the reference BlueZ file examples, though I admit it still looks a little messy. Most of this is a result of real testing with Bluetooth devices, hence some of the defensive code additions. I've tried to document them to keep them a bit more readable.