feat: rulebook mechanism, static engine and check CLI (P1, v1.2.0) - #11
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First slice of the rulebook mechanism (P1 of the Jev plan): a machine-readable rulebook (YAML, validated with Zod at runtime), a dependency-free static engine, the
nestjs-hexagonal-checkCLI, therun.shentry point with the per-project opt-in gate, golden fixtures and CI. Semantic rules are declared (questions, state slices, per-primitive thresholds) but inert: nothing is sent to any network in this version, and the tests assert thatfetchis never called.rulebooks/hexagonal.rulebook.yaml(18 rules: 12 static, 5 semantic, 1 runtime) andrulebooks/softtor-conventions.rulebook.yaml(3 static), each rule pointing at itsreview-subdomaincheck orarchitecture-reviewersmell;rulebooks/project.example.rulebook.yamlshowsextendswith sha256 stamps and an override.scripts/check.ts:--rulebook <path|id>,--project-rulebook,--files,--diff <base>,--classes,--format json|text,--strict,--explain.scripts/run.sh(POSIX sh): opt-in gate (no.claude/rulebook.yamland noNESTJS_HEXAGONAL_RULEBOOK→ exit 0),NESTJS_HEXAGONAL_DISABLE=1, path containment, single execution source (projectnode_modules/.binpreferred), fail-open with an actionable message,bun→nodefallback.package.json+bun.lock(deps:zod,yaml; devDependency@types/bun), nobunfig.toml, no lifecycle scripts; version1.2.0-dev.0inpackage.json,plugin.jsonandmarketplace.jsonwith a CI parity check.bun test ./scripts),tsc --noEmitclean,examples/passes--strictwith 0 FAIL.Design notes and deviations from the plan are listed in the commits and in
CLAUDE.md/README.md("Rulebook & CLI"). Hooks (hooks/hooks.json), the Jev client and calibration come in the next PRs (P2/P3).How to test