Bump firewall image to 2.1.1 (Helm + CloudFormation) - #23
Merged
Conversation
Updates the Helm chart appVersion and every image tag pin to 2.1.1, and the chart version to 0.11.2, across the Helm chart and the CloudFormation templates and example values. Main was still pinned to 2.0.14, so this skips the 2.0.15 through 2.1.0 releases.
lelia
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Cursor:opus-5
What & why
Pins the customer-facing deployment artifacts to firewall image
2.1.1and the Helm chartversionto0.11.2.mainwas still on2.0.14, so this crosses four releases; the one that motivates shipping it now is2.1.1, which fixes a failure specific to this chart's own hardening. The chart mounts the TLS secret at/etc/nginx/sslread-only, and the config tool wrote its combined CA bundle into that same directory. The write failed, the failure was swallowed and then contradicted by a success log line, and startup continued on operating-system roots alone — so a deployment configuring a private CA for Redis TLS lost it silently and failed every handshake.2.1.1writes the bundle to/app/ca-bundle.peminstead.Supersedes #22, which bumped to
2.1.0and claimed the same chart version.How it works
Nine version strings across six files, the same set #21 touched.
Chart.yamlappVersionis the real source of truth —_helpers.tplfalls back to it — butvalues.yaml, the CloudFormation parameter defaults, the example values file, and both READMEs each carry their own copy that has to be moved in lockstep.No chart template changes, hence a patch chart bump rather than a minor.
What to look at first
That
helm/Chart.yamlappVersionand theFirewallImageTagdefault incloudformation/firewall-eks.yamlagree. The CloudFormation parameter is a separate pin by design (so stacks don't drift when the chart'sappVersionmoves independently), which also means nothing enforces that the two match.Testing
helm lintpasses, andhelm templaterenderssocketdev/socket-registry-firewall:2.1.1withapp.kubernetes.io/version: "2.1.1". Grepping the tree for the old2.0.14and0.11.1strings returns nothing.The image itself is not exercised here.
Notes
Merging this publishes chart
0.11.2to the public Helm repo immediately — the release workflow fires on anyhelm/Chart.yamlchange tomain. So this should not merge until the2.1.1image is on Docker Hub, or the published chart will point at a tag that cannot be pulled.metrics.minImageVersionstays at1.1.343. It is a floor for gating the metrics endpoint, not a pin, and2.1.1clears it.Note
Low Risk
Version-string and documentation updates only; no runtime logic or chart template changes, though merging publishes chart 0.11.2 and assumes the 2.1.1 image is pullable.
Overview
Pins customer-facing deployment artifacts to firewall image
2.1.1and bumps the Helm chartversionto0.11.2(patch only—no template changes).Helm:
Chart.yamlappVersionmoves to2.1.1;helm/values.yamlandhelm/README.mddefaultimage.tagdocumentation match. CloudFormation EKS:firewall-eks.yamldefaults forChartVersion(0.11.2) andFirewallImageTag(2.1.1), plusvalues/dns-override.values.yamlandcloudformation/README.mdprose, stay in lockstep with the chart pins.Shipping
2.1.1matters for Helm hardening: the image no longer writes a combined CA bundle into the read-only TLS mount (/etc/nginx/ssl), which could silently drop private Redis CA trust; the bundle is written under/app/ca-bundle.peminstead.Reviewed by Cursor Bugbot for commit 5166e32. Configure here.