Skip to content

Adding service.externalTrafficPolicy to the Helm chart #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Phil Gran (philgran) merged 3 commits into from
Jul 17, 2026
Merged

Adding service.externalTrafficPolicy to the Helm chart #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ab68b4
Adding an externalTrafficPolicy to allow load balancers to keep traff…
philgran Jul 16, 2026
b1a70dc
Incrementing version to latest
philgran Jul 16, 2026
c5ac772
Incrementing version
philgran Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helm/.gitignore → .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ charts/
# IDE
.idea/
.vscode/
settings.json
*.swp
*.swo

Expand Down
4 changes: 2 additions & 2 deletions helm/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ apiVersion: v2
name: socket-firewall
description: Socket.dev Registry Firewall - Block vulnerable packages before they reach your cluster
type: application
version: 0.8.0
version: 0.9.0
# appVersion is the single source of truth for the firewall image version.
# image.tag in values.yaml defaults to this (see templates/_helpers.tpl).
appVersion: "2.0.3"
appVersion: "2.0.5"
keywords:
- security
- supply-chain
Expand Down
1 change: 1 addition & 0 deletions helm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ registries:
| `tls.generateSelfSigned` | Generate self-signed certs | `true` |
| `tls.existingSecret` | Use existing TLS secret | `""` |
| `service.type` | Service type | `ClusterIP` |
| `service.externalTrafficPolicy` | `Cluster` or `Local` (NodePort/LoadBalancer only); use `Local` to preserve client source IPs | `""` |
| `ingress.enabled` | Enable Ingress | `false` |
| `ingress.className` | Ingress class (nginx, alb, traefik) | `""` |
| `autoscaling.enabled` | Enable HorizontalPodAutoscaler | `false` |
Expand Down
3 changes: 3 additions & 0 deletions helm/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ metadata:
{{- end }}
spec:
type: {{ .Values.service.type }}
{{- if and .Values.service.externalTrafficPolicy (has .Values.service.type (list "NodePort" "LoadBalancer")) }}
externalTrafficPolicy: {{ .Values.service.externalTrafficPolicy }}
{{- end }}
ports:
- port: {{ .Values.service.httpPort }}
targetPort: http
Expand Down
6 changes: 6 additions & 0 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,6 +600,12 @@ service:
containerHttpsPort: ""
# Override HTTPS targetPort (set to "http" when TLS is terminated at the load balancer)
httpsTargetPort: ""
# External traffic policy (Cluster or Local). Only applies when type is
# NodePort or LoadBalancer. Set to "Local" to preserve client source IPs;
# the default "Cluster" policy SNATs traffic forwarded across nodes (e.g. to
# a link-local 169.254.x.x address on GKE Dataplane v2 passthrough LBs).
# Note: with "Local", only nodes running a firewall pod receive traffic.
externalTrafficPolicy: ""
annotations: {}
# service.beta.kubernetes.io/aws-load-balancer-internal: "true"
# service.beta.kubernetes.io/aws-load-balancer-scheme: "internal"
Expand Down