Skip to content

Keep coverage's instrumented binary under the update cap #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Keep coverage's instrumented binary under the update cap #2071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,16 @@ jobs:
contents: read
env:
VEXCTL_VERSION: v0.3.0
# No DWARF in the instrumented build. llvm-cov maps coverage from
# the __llvm_cov* sections, not debug info, and a panic's location
# comes from #[track_caller], so neither the LCOV nor the failure
# annotations change. The self-update e2e suites serve this very
# binary as a release asset, and the updater refuses one over its
# 256 MiB cap (MAX_BINARY_BYTES in update/download.rs). With
# line-tables-only the instrumented socket-patch was ~274 MB
# locally (~107 MB of it .debug_*), and feat/bazel-support crossed
# the cap in CI; without DWARF it is ~163 MB.
CARGO_PROFILE_DEV_DEBUG: '0'
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand Down
Loading