Fix Windows nightly test failures and absolute --patch-dir bound (#2049)

* Fix 7 Windows-only test failures in nightly CI

The scheduled CI run has been red on main for five nights. Its
`test (windows-latest, 1|2)` legs (nightly-only) fail seven tests
that pass on Linux and macOS, all from test-side assumptions about
Unix paths:

- an_absolute_patch_dir_inside_the_repository_is_read built its
  package.json with format!, so the Windows path's backslashes were
  invalid JSON escapes; build it with serde_json instead.
- five assertions matched `/`-separated substrings in user-facing
  detail text that Windows prints with `\`; compare after mapping
  `\` to `/`.
- pnpm_workspace_file_above_the_repository_fails_closed expected the
  canonical `\\?\` path, but governing_workspace_file deliberately
  strips that prefix; expect without_verbatim_prefix(file).

No production code changes; every assertion still checks the same
path on every OS.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011f9aeRDbxjatib28cpxPqQ

* Read a user-typed absolute --patch-dir as in-repo

On Windows the bound's repository root is canonical (`\\?\C:\...`)
while a script names its patch directory as users type it
(`C:\...`), and Path::starts_with treats the verbatim and plain disk
prefixes as different. Every absolute in-repo `--patch-dir` was
reported as outside the repository, protecting every npm package.
Compare both sides without the verbatim prefix, and make the test
spell the directory the way a user does (quoted, unprefixed).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011f9aeRDbxjatib28cpxPqQ

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: mikolalysenko

crates/socket-patch-cli/tests/hosted_memory_engine.rs

@@ -2281,7 +2281,9 @@ async fn user_patched_npm_packages_are_never_pinned() {
             .unwrap_or_else(|| panic!("{fixture} {file}: {:?}", project.skipped));
         assert_eq!(skip.purl, "pkg:npm/left-pad@1.3.0");
         assert!(
-            skip.detail.as_deref().is_some_and(|d| d.contains(file)),
+            skip.detail
+                .as_deref()
+                .is_some_and(|d| d.replace('\\', "/").contains(file)),
             "{fixture}: {:?}",
             skip.detail
         );

crates/socket-patch-core/src/patch/user_patches.rs

@@ -1232,7 +1232,12 @@ impl Bound {
                     )
             }
             Bound::Disk { root, repo } => {
-                !normalize_lexically_keeping_escapes(&root.join(rel)).starts_with(repo)
+                // `repo` is canonical (`\\?\C:\...` on Windows) while a
+                // script names a directory as users type it (`C:\...`), and
+                // `starts_with` treats the two prefixes as different.
+                use crate::utils::pnpm_workspace::without_verbatim_prefix;
+                !without_verbatim_prefix(normalize_lexically_keeping_escapes(&root.join(rel)))
+                    .starts_with(without_verbatim_prefix(repo.clone()))
             }
         }
     }
@@ -2058,14 +2063,14 @@ mod tests {
         assert!(
             left_pad
                 .iter()
-                .any(|s| s.ends_with("fixes/left-pad+1.3.0.patch")),
+                .any(|s| s.replace('\\', "/").ends_with("fixes/left-pad+1.3.0.patch")),
             "{left_pad:?}"
         );
         let is_number = global.conflicts("pkg:npm/is-number@7.0.0");
         assert!(
-            is_number
-                .iter()
-                .any(|s| s.ends_with("shared/a/patches/is-number+7.0.0.patch")),
+            is_number.iter().any(|s| s
+                .replace('\\', "/")
+                .ends_with("shared/a/patches/is-number+7.0.0.patch")),
             "{is_number:?}"
         );
         assert!(global.conflicts("pkg:npm/right-pad@1.3.0").is_empty());
@@ -2115,15 +2120,17 @@ mod tests {
         let tmp = tempfile::tempdir().unwrap();
         let repo = std::fs::canonicalize(tmp.path()).unwrap();
         write(&repo, ".git/HEAD", "ref: refs/heads/main\n");
-        let fixes = repo.join("fixes");
-        write(
-            &repo,
-            "package.json",
-            &format!(
-                r#"{{"scripts":{{"postinstall":"patch-package --patch-dir {}"}}}}"#,
-                fixes.display()
-            ),
-        );
+        // Spelled as a user types it: on Windows without the `\\?\` prefix
+        // `canonicalize` adds to `repo`, quoted in case the temp dir has a
+        // space, and built as JSON so its backslashes are escaped.
+        let fixes =
+            crate::utils::pnpm_workspace::without_verbatim_prefix(repo.clone()).join("fixes");
+        let manifest = serde_json::json!({
+            "scripts": {
+                "postinstall": format!("patch-package --patch-dir \"{}\"", fixes.display())
+            }
+        });
+        write(&repo, "package.json", &manifest.to_string());
         write(&repo, "fixes/left-pad+1.3.0.patch", "diff\n");
         let index = UserPatchIndex::discover(&repo).await;
         assert!(

crates/socket-patch-core/src/utils/cargo_build_cache.rs

@@ -437,7 +437,13 @@ mod tests {
         .unwrap();
         let warnings = invalidate_project(ReadScope::Workspace, &app, purls);
         assert_eq!(warnings.len(), 1, "{warnings:?}");
-        assert!(warnings[0].1.contains(".cargo/config.toml"), "{warnings:?}");
+        assert!(
+            warnings[0]
+                .1
+                .replace('\\', "/")
+                .contains(".cargo/config.toml"),
+            "{warnings:?}"
+        );
         // A global run reads it as before.
         assert!(invalidate_project(ReadScope::Global, &app, purls).is_empty());
     }

crates/socket-patch-core/src/utils/repo_root_upward_tests.rs

@@ -135,7 +135,8 @@ fn pnpm_workspace_file_above_the_repository_fails_closed() {
     write(&file, "packages:\n  - other\n");
     assert_eq!(
         crate::utils::pnpm_workspace::governing_workspace_file(&l.app),
-        Some(file)
+        // Reported without Windows' `\\?\` prefix, which `layout` keeps.
+        Some(crate::utils::pnpm_workspace::without_verbatim_prefix(file))
     );
     let plain = layout(false);
     write(

crates/socket-patch-core/src/vex/discover/user_patched.rs

@@ -328,6 +328,7 @@ mod tests {
             assert!(
                 out.unattested[0]
                     .detail
+                    .replace('\\', "/")
                     .contains("patches/left-pad+1.3.0.patch"),
                 "{}",
                 out.unattested[0].detail
@@ -420,7 +421,7 @@ mod tests {
             all_marked(&out, what);
             let member = files[files.len() - 1].0.rsplit_once('/').unwrap().0;
             assert!(
-                out.unattested[0].detail.contains(member),
+                out.unattested[0].detail.replace('\\', "/").contains(member),
                 "{what}: {}",
                 out.unattested[0].detail
             );