Skip to content

Commit 113ea6a

Browse files
Expect the unchecked advisory in vlt migration 8 (#2050)
Nightly CI on main has failed every mode_migration_vlt leg (ubuntu x3, macOS, Windows x2) since #2021. That PR made the vlt warm-tree heal judge a store entry by vlt's hidden lock alone: without one, the copy is kept and reported as unchecked ("could not check N installed copies ... run `vlt ci`"). It updated the rule (c) e2e in e2e_redirect_vlt_build.rs but missed its twin here, migration test 8, which removes the hidden lock and still expected the "nothing stale" advisory. These legs run only at night, so PR and merge-queue CI never saw it. Expect advisory_undeterminable(ids.len()), as the rule (c) test does. The store copies are still kept and the tree stays patched. Claude-Session: https://claude.ai/code/session_011f9aeQSeGNDaC689NLWPom Co-authored-by: Claude <noreply@anthropic.com>
1 parent c751724 commit 113ea6a

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

‎crates/socket-patch-cli/tests/mode_migration_vlt.rs‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -570,8 +570,10 @@ async fn vlt_pinned_matrix_migration_agent_apply_after_hosted() {
570570
fx.leg.ran();
571571
}
572572

573-
/// 8: a hosted scan over an agent-patched warm tree keeps the tree (heal
574-
/// rule (c) sees the afterHash pass): nothing is invalidated.
573+
/// 8: a hosted scan over an agent-patched warm tree with no hidden lock
574+
/// keeps the tree. Hosted scans fetch no patch record, so nothing proves
575+
/// which bytes the store copy holds: heal rule (c) reports it as
576+
/// unchecked and asks for `vlt ci`, and nothing is invalidated.
575577
#[tokio::test(flavor = "multi_thread")]
576578
#[ignore = "real vlt: SOCKET_PATCH_VLT_E2E_JS"]
577579
async fn vlt_pinned_matrix_migration_hosted_scan_keeps_agent_patched_tree() {
@@ -586,7 +588,7 @@ async fn vlt_pinned_matrix_migration_hosted_scan_keeps_agent_patched_tree() {
586588
let _ = std::fs::remove_file(fx.proj.join(HIDDEN_LOCK));
587589
let ids = fx.store_ids(fx.t());
588590
let doc = fx.scan(&[]);
589-
fx.assert_advisory(&doc, &advisory_nothing_stale());
591+
fx.assert_advisory(&doc, &advisory_undeterminable(ids.len()));
590592
for id in &ids {
591593
assert!(store_entry(&fx.proj, id).exists(), "{id} kept");
592594
}

0 commit comments

Comments
 (0)