Repository navigation
refactor(manifest): give a Maven sibling's jar and test-jar their own ids - #1716
Merged
Jeppe Fredsgaard Blaabjerg (jfblaa) merged 2 commits intoNov 12, 2026
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Claude Code:claude-opus-5-5
The Maven facts extension wrote a reactor sibling's jar and its test-jar under one bare
groupId:artifactId:versionid. So one record node mixed the two artifacts' scopes, directness and children, and the walk needed special cases for it. Each artifact now has its own coordinate and names the sibling module as its project. The assembler already merges a project's artifacts into its component, as it does for Gradle variants, so the facts are unchanged. On the compat fixture,socket manifest mavenoutput is identical with the old and new extension.The fixture now pins the per-artifact records:
demo.ext:libdephangs under the test-jar, not the jar, since mid excludes it from lib.Maven compat matrix 3.2.5 to 4.0.0-rc-6 green. Suggested in the review of #1711.
Resolves REA-1165.
🤖 Generated with Claude Code