fix(ci): scope artifact paths to current version dir; robust release publish - #52
Merged
Merged
Conversation
…on dir firmware/ also contains ~128 committed historical binaries; the previous globs uploaded all of them (2.7GB of artifacts for one release build). Release uploads now take only firmware/<tag>/, PR test builds only firmware/dev/ (shallow checkouts make post_build_merge.py fall back to 'dev'). Release publishing moves to softprops/action-gh-release@v2 after gh asset upload 404'd twice from the runner. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2.9.6-pre release run exposed three issues, fixed here:
nn1. Wrong artifact scope —firmware/**/*.binalso matched the ~128 committed historical binaries (2.7GB of artifacts per release; same over-upload on every PR test build).nn2. Release publish viaghfailed twice in-runner (no-git-remote, then a 404 on uploads.github.com); switching tosoftprops/action-gh-release@v2.nn3. Release uploads now restricted to the tag's ownfirmware//output dir.nnThe v2.9.6-pre release itself was published manually from the run's successful artifacts (34 binaries, 17 targets) — this fixes future tags.