Repository navigation
[Sync] Export changes from internal SnapRHI (1245aee6) - #12
Merged
Merged
Conversation
Automated sync from github.sc-corp.net/Snapchat/SnapRHI-Internal Internal commit: 1245aee65026db3f6ff122dcfc3c95577d0b671e Changed files: 415 Insertions: +24847, Deletions: -12207
small_vector::inline_ptr() used reinterpret_cast<T*> on raw byte storage, which older Apple clang rejects under ARC when T is an id<> pointer type (ResourceBatcher's small_vector<id<MTLResource>, N>). Route through void*/const void* instead, which ARC treats as a bridge-safe conversion. Also request the com.lunarg.vulkan.ios component when installing the Vulkan SDK for iOS CI jobs — GLAD's iOS Vulkan default switched to Framework mode, which needs vulkan.framework from that component. Same fix applied upstream: github.sc-corp.net/Snapchat/SnapRHI-Internal/pull/1403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Sync: Internal → Public
This PR exports the latest changes from the internal SnapRHI repository into the public repository.
Source
main1245aee6Summary
6c69006b)Build verification (before opening this PR)
Built and tested this exact branch locally on macOS (Apple M5 Max) prior to opening the PR:
Synced content
src/(backend, interop, public-api)CMakeLists.txt,CMakePresets.json,build.sh,cmake/docs/,README.md,CONTRIBUTING.mdexamples/third-party/.github/(CODEOWNERS, templates, CI).clang-format,.editorconfig,.gitignore, etc.LICENSE.md,CODE_OF_CONDUCT.md,SECURITY.md