Skip to content

image-copy: properly handle capture session destruction for cursor sessions - #2170

Open
pgaskin wants to merge 1 commit into
Smithay:masterfrom
pgaskin:ext-image-copy-capture-cursor-session-destroy
Open

pgaskin wants to merge 1 commit into
Smithay:masterfrom
pgaskin:ext-image-copy-capture-cursor-session-destroy

Conversation

@pgaskin

@pgaskin pgaskin commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Previously, destroying the capture session wouldn't destroy the cursor session and fail the frames like it does when destroying the cursor session itself, or regular sessions.

Tested with niri-wm/niri#4554.

cc @YaLTeR

Checklist

@pgaskin

pgaskin commented Sep 13, 2026

Copy link
Copy Markdown
Contributor Author

Not directly related to this PR, but @ids1024 may be interested in niri-wm/niri#4554 (comment) (cosmic implements frame handling on session destruction differently than the others).

Comment thread src/wayland/image_copy_capture/mod.rs Outdated
@pgaskin
pgaskin force-pushed the ext-image-copy-capture-cursor-session-destroy branch 2 times, most recently from 77fad1a to 9abb087 Compare October 8, 2026 02:51
…ssions

Previously, destroying the capture session wouldn't destroy the cursor
session and fail the frames like it does when destroying the cursor
session itself, or regular sessions.
@pgaskin
pgaskin force-pushed the ext-image-copy-capture-cursor-session-destroy branch from 9abb087 to 52c471f Compare October 10, 2026 07:13
@pgaskin
pgaskin requested a review from ids1024 October 10, 2026 07:13
@pgaskin

pgaskin commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

Rebased, added CursorCaptureSessionData, fixed build.

@YaLTeR @ids1024

pgaskin added a commit to pgaskin/niri that referenced this pull request Oct 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants