Skip to content
This repository was archived by the owner on Aug 5, 2026. It is now read-only.

chore: V43 major regression test-3 - #4660

Closed
Richard-Shen (RichardSyq) wants to merge 3 commits into
mainfrom
major-43-test-3
Closed

Richard-Shen (RichardSyq) wants to merge 3 commits into
mainfrom
major-43-test-3

Conversation

@RichardSyq

@RichardSyq Richard-Shen (RichardSyq) commented Jun 2, 2026 •

Copy link
Copy Markdown
Contributor

V43 Major Regression Branch

This is a combined draft PR aggregating all approved major-labelled PRs for the upcoming V43 major release.

⚠️ DO NOT MERGE — This branch is for regression testing only.

Merged PRs

# PR Title Author
1 #4553 [NO-JIRA][BpkCardList] Remove initiallyInViewCardIndex prop Jimmy cook (@jimmycook)

Notes

  • Branch created from origin/main at ac522e5ef
  • Local verification: install ✅ build ✅ lint ✅ jest ✅ | pristine ⚠️ (Conductor skill files) typecheck ⚠️ (pre-existing TS errors on main)

Jimmy cook (jimmycook) and others added 3 commits May 22, 2026 15:39
The prop relied on scrollIntoView from a useEffect on mount, which
silently no-ops when the carousel is rendered inside a parent that
hasn't laid out yet (e.g. AnimateHeight at display: none). The sole
intended consumer (ExpandedPricingOption in web-platform) hit exactly
this and has since switched to a manual ref-based scroll triggered
after its parent's animation completes (IRN-6568). No other consumers
exist, so the prop is dead weight with a misleading API.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@skyscanner-backpack-bot

Copy link
Copy Markdown
Contributor

Visit https://backpack.github.io/storybook-prs/4660 to see this build running in a browser.

@skyscanner-backpack-bot

skyscanner-backpack-bot Bot commented Jun 2, 2026 •

Copy link
Copy Markdown
Contributor

Dev Release Published

Version: 42.23.0-dev-v26810456218.1

Install with:

npm install @skyscanner/backpack-web@42.23.0-dev-v26810456218.1

You can also use the dev tag to install the latest dev release:

npm install @skyscanner/backpack-web@dev

Published from commit d034c1a by Richard-Shen (@RichardSyq).

@skyscanner-backpack-bot

Copy link
Copy Markdown
Contributor
Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against d034c1a

This branch was previously deployed

1 inactive deployment
Publishing — d034c1ae Deployed Jun 2, 2026 by RichardSyq via Build and publish dev release #65
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants