Support GPG signing in revup#257
Closed
anurag-makineni-wayve wants to merge 1 commit into
Closed
Conversation
Topic: gpg
Collaborator
|
thanks! i made a few changes, since i don't think we need our own config variable if we're just obeying git's. can you review #264 and approve if that works for you? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jerry-skydio!
I was having some trouble using revup on repositories that enforce signed commits. Even though the commits I was making on my local branch were signed, the cherry-picks revup was making were not carrying the signatures over.
This PR adds support to do so by passing the
-Stogit commit-treebased on the git config'scommit.gpgSignvalue if the--gpg-signarg is not specified.Let me know if you have any feedback!