wallet: fill in the wallet's HD keys when importing a descriptor - #127
Open
Sjors wants to merge 2 commits into
Open
wallet: fill in the wallet's HD keys when importing a descriptor#127Sjors wants to merge 2 commits into
Sjors wants to merge 2 commits into
Conversation
Add an optional Parse() input with extended private keys known to the caller, by their public form, used to fill in the extended public keys of the descriptor as if it contained the private keys. ParseState carries it through the parsers, including Miniscript keys and musig() participants. A key expression with an explicit origin that leads from a known key to its extended public key is replaced by that key and the full derivation path, matching a descriptor that contains the known key. A known extended public key without such an origin keeps its expression and only gains the private key. Known keys do not change the multipath descriptor output.
When importdescriptors is given a descriptor with extended public keys of the wallet's HD keys, or keys with an origin from them, fill in the private keys, so that such descriptors can be imported into wallets with private keys enabled.
Sjors
force-pushed
the
2026/09/parse-known-keys
branch
from
September 3, 2026 06:43
4439504 to
11f7606
Compare
Sjors
added a commit
that referenced
this pull request
Sep 3, 2026
Sjors
added a commit
that referenced
this pull request
Sep 3, 2026
bitcoin#33112 tests walletdisplayaddress for an imported external-signer descriptor using the same xpub as a wallet exercised earlier in wallet_signer.py. bitcoin#36114 then revamps the shared external signer mock used by the test. With #127, the imported descriptor's known HD keys are filled immediately, so its first address is recognized as used and the wallet advances to the next index, which the mock intentionally maps to wrong_address for a separate error case. Let the test configure the address echoed by the mock so it remains independent of the derived index while preserving the mismatched-address coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept alternative approach to bitcoin#32861.
Based on bitcoin#36133.