experiments: hide disabled connections; bump engine to 0.3.0 - #7
Merged
Merged
Conversation
The New Experiment Models list was built from visible_connections_for(), which filters only by sharing rules and ignored the ModelConnection.enabled flag. A connection disabled on /connections/ still appeared (and its models could be picked), contradicting the 'disabled' badge there. Filter disabled connections out of the picker so their models can't be selected for new runs.
The local editable ../SimpleAudit checkout is at 0.3.0 (matching the latest release), but Studio pinned ==0.2.3, causing a version mismatch. Bump the pin and re-lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes:
Fix: disabled connections still appeared in the New Experiment Models list.
The picker was built from
visible_connections_for(), which filters only by sharing rules (owner / public / admin / explicit) and ignored theModelConnection.enabledflag. A connection disabled on/connections/still showed up — and its models could be picked — contradicting the "disabled" badge (tooltip: Its models can't be picked for new runs) on that page. Disabled connections are now filtered out of the picker so their models can't be selected. The/connections/page is unchanged (still lists them, badged).Chore: bump the
simpleauditengine pin 0.2.3 → 0.3.0.The local editable
../SimpleAuditcheckout is at 0.3.0 (the latest release), but Studio pinned==0.2.3, a version mismatch. Bumped the pin and re-locked.Testing
PickerSharingTests(disabled owner connection hidden, enabled connection still shown, disabled shared connection hidden from consumer).infra/tests/suite: 546 passed, 2 skipped (both skips environment-specific, unrelated).