Repository navigation
Raise the artifact limits to 100 MB a file and 250 MB a build - #45
Merged
Merged
Conversation
A 24 MB artifact was left out of a triage as over the 20 MB limit for one file. The per file cap is now 100 MB, and the total goes from 50 MB to 250 MB with it: a cap above the budget is never reached, since anything over the budget is skipped for that reason instead. Bumps the version to 1.0.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 24 MB artifact was left out of a triage download as "over the 20 MB limit for one file".
ArtifactPlan.DefaultPerFilegoes from 20 MB to 100 MB.ArtifactPlan.DefaultBudgetgoes from 50 MB to 250 MB. A per file cap above the total is never reached, since anything over the budget is skipped for that reason instead, so the total moves with it and keeps the same 2.5x ratio.docs/mcp.mdand its source say the new figures.Not changed
The MCP side waits at most five minutes for a triage download (
ProtocolClient.Limit). A full 250 MB needs about 7 Mbit/s sustained to land inside that, so a large bundle on a slow link can now time out where it used to fit.Testing
BuildMonitor.Testsin Debug: 1522 passed, 13 skipped on Windows.