fix: Auto-scroll crashes when target unmounts mid-scroll β re-check mounted after await - #664
Open
Fellmonkey wants to merge 1 commit into
Conversation
apurva010
force-pushed
the
fix/autoscroll-unmounted-context
branch
from
September 10, 2026 11:00
4844606 to
c3c15b7
Compare
apurva010
changed the base branch from
master
to
fix/issue_659_null_check_error_on_register_state_disposed
September 10, 2026 11:01
apurva010
force-pushed
the
fix/autoscroll-unmounted-context
branch
from
September 10, 2026 11:02
c3c15b7 to
7d57617
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
scrollIntoView()only checked_mountedbeforeawait Scrollable.ensureVisible(_context). After the await,_waitForScrollToSettle()read_contextwithout re-checkingmounted, so atarget that unmounted during the scroll (e.g. the page rebuilt after async
data arrived) crashed with:
This widget has been unmounted, so the State no longer has a contextThis PR re-checks
_mountedafter eachawaitand bails out of the scrollinstead of touching the defunct context.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #662 (also relates to the earlier #313)