fix: Crash on rapid taps / tour reset - reverse() called after dispose - #663
Open
Fellmonkey wants to merge 1 commit into
Conversation
apurva010
force-pushed
the
fix/reverse-after-dispose
branch
2 times, most recently
from
September 10, 2026 10:49
779aca9 to
aa68d6d
Compare
apurva010
changed the base branch from
master
to
fix/issue_659_null_check_error_on_register_state_disposed
September 10, 2026 10:51
apurva010
force-pushed
the
fix/reverse-after-dispose
branch
2 times, most recently
from
September 10, 2026 10:59
98da790 to
53bc876
Compare
…owcase advances mid-animation (SimformSolutionsPvtLtd#661)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
reverseAnimationCallbackwas assigned the raw method tear-off_scaleAnimationController.reverseand never cleared indispose(). When ashowcase sequence is reset or advanced quickly (rapid taps on consecutive
tooltips), a pending
_onComplete()invokedreverse()on a controller thathad already been disposed, throwing:
AnimationController.reverse() called after AnimationController.dispose()This PR wraps the callback in a closure that no-ops once the tooltip is
disposed, and nulls it in
dispose().Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #661