Option to set error thrown at maximum iterations reached to warning - #242
Open
KatrinKoesler wants to merge 7 commits into
Open
Option to set error thrown at maximum iterations reached to warning#242KatrinKoesler wants to merge 7 commits into
KatrinKoesler wants to merge 7 commits into
Conversation
…terations is reached. This is specified in the input file with the parameter "max_iter_warning". If true, a warning is printed, if false (default) the error is thrown.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Option to set error thrown at maximum iterations reached to warning
Current situation
This pull request addresses #241. Outputs are currently not written when the maximum number of Newton-iterations for a time step is reached since this throws an error. For testing of simulations having the outputs written would be helpful for debugging.
Release Notes
Added the input file option "max_iter_warning" with default false (I.e. throws an error; if true is chosen there will be a warning but the simulation continues running and will write an output).
Testing
All tests run
Code of Conduct & Contributing Guidelines