Use IOM.ComponentPairKey - #328
Open
acostarelli wants to merge 2 commits into
Open
acostarelli wants to merge 2 commits into
acostarelli wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical reserve-group duplication and hydro lookup issues remain, along with stale IOM feature-branch pins.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
This pull request migrates reserve-variable storage and access to IOM.ComponentPairKey, separating containers by device and service type.
Changes:
- Updates reserve construction, grouping, constraints, costs, and device integrations.
- Revises reserve-related tests and output lookups.
- Updates IOM dependency pins.
| File | Summary |
|---|---|
test/test_services_constructor.jl |
Updates reserve container assertions. |
test/test_model_decision.jl |
Updates reserve output discovery. |
test/test_device_reserve_offers.jl |
Updates reserve award reads and assertions. |
test/Project.toml |
Should pin IOM to main instead of the stale feature branch. |
src/static_injector_models/hydro_generation.jl |
Uses pair-keyed hydro reserve variables; remaining old lookup callers must be updated. |
src/services_models/services_constructor.jl |
Creates pair-keyed reserve containers. |
src/services_models/reserves.jl |
Updates reserve constraints and costs. |
src/services_models/reserve_offers.jl |
Handles pair-keyed offer pricing. |
src/services_models/reserve_group.jl |
Aggregates pair-keyed awards; canonicalize scanned keys to prevent duplicate aggregation. |
src/hybrid_system_models/hybrid_systems.jl |
Updates hybrid reserve access. |
src/energy_storage_models/storage_models.jl |
Updates storage reserve access. |
src/core/reserve_traits.jl |
Updates offline reserve award lookup. |
src/common_models/add_to_expression.jl |
Updates reserve expression wiring. |
Project.toml |
Should pin IOM to main instead of the stale feature branch. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -216,11 +219,27 @@ function _group_member_variables( | |||
| rtype = typeof(r) | |||
Comment on lines
+2808
to
+2809
| variable = | ||
| get_variable(container, U, IOM.ComponentPairKey{V, typeof(service)}) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.