area copperplate balance duals - #326
Open
acostarelli wants to merge 2 commits into
Open
acostarelli wants to merge 2 commits into
acostarelli wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add the missing PSY.Area dual calculation method to prevent failures during dual output processing.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Adds area-level copperplate balance dual registration for area-based network models.
Changes:
- Registers area-keyed dual containers.
- Adds regression tests for area balance and PTDF formulations.
| File | Description |
|---|---|
test/test_network_constructors.jl |
Tests area-level dual availability and outputs. |
src/network_models/copperplate_model.jl |
Registers area-level dual containers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| time_steps = get_time_steps(container) | ||
| existing = get_constraint(container, CopperPlateBalanceConstraint(), PSY.Area) | ||
| area_names = axes(existing)[1] | ||
| add_dual_container!(container, CopperPlateBalanceConstraint, PSY.Area, area_names, time_steps) |
Member
Author
There was a problem hiding this comment.
It falls back to IOM I believe
|
Performance Results
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jd-lara
reviewed
Sep 24, 2026
| sys::PSY.System, | ||
| model::NetworkModel{T}, | ||
| ) where {T <: Union{CopperPlateNetworkModel, AbstractPTDFNetworkModel}} | ||
| ) where { |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #293