G-1 reserves; use IOM.ComponentPairKey; EnumX changes by acostarelli · Pull Request #321 · Sienna-Platform/PowerOperationsModels.jl

acostarelli · 2026-09-23T03:31:19Z

Requires Sienna-Platform/InfrastructureOptimizationModels.jl#171

…straint and slacks on flow

… slacks keys need to be reconsidered I think

…of reserves code; enumx

Copilot

Copilot review overview

🟡 Changes recommended

Unresolved critical dependency, test, reserve-keying, and G-1 monitoring issues block approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 6 · 3

Open (9)

Include device type in participation constraint keys · New
Fix inverted modeled branch type condition · New
Use a portable remote path for the test dependency · New
Restore the compatible PowerFlows source pin · New
Restore the PowerFlows test import · New
Handle absent requirement containers in the test · New
Restore the HVDCDCControlConstraint public export · New
Restore system snapshot persistence in system_to_file · New
Validate monitored branches against the filtered catalog · New

What changed in this PR

Ports G-1 security-constrained reserve modeling, migrates reserve indexing to IOM.ComponentPairKey, and updates related models and tests.

Changes:

Adds post-contingency reserve deployment, balance, flow, and slack modeling.
Updates reserve construction, aggregation, offers, and device integrations.
Updates EnumX handling, dependencies, output persistence, and regression coverage.

File	Changes	Final review findings
`test/test_static_injection_security_constrained_models.jl`	Adds G-1 regression coverage.	Critical (1): No-requirement test checks an absent container incorrectly.
`test/test_services_constructor.jl`	Updates reserve-container assertions.	—
`test/test_model_decision.jl`	Adapts reserve output discovery.	—
`test/test_device_reserve_offers.jl`	Reads typed reserve awards.	—
`test/Project.toml`	Updates test dependencies and sources.	Critical (3): Contributor-specific absolute path. Critical (3): Removed compatible remote source while PowerFlows tests remain enabled.
`test/includes.jl`	Changes test imports.	Critical (3): `PFS` import is disabled while dependent tests remain enabled.
`src/static_injector_models/thermal_generation.jl`	Updates offline reserve lookup.	—
`src/static_injector_models/hydro_generation.jl`	Updates reserve variable keys.	—
`src/services_models/services_constructor.jl`	Constructs security-constrained service models.	—
`src/services_models/security_constrained_injectors.jl`	Implements G-1 reserve modeling.	Critical (1): Modeled branch types are skipped due to an inverted condition. Moderate (2): Validation ignores the per-device `filter_function`.
`src/services_models/reserves.jl`	Migrates reserve aggregation and costs.	Critical (1): Participation constraints can collide without device-type keys.
`src/services_models/reserve_offers.jl`	Supports device-type offer keys.	—
`src/services_models/reserve_group.jl`	Aggregates pair-keyed reserve variables.	—
`src/PowerOperationsModels.jl`	Registers and exports G-1 APIs.	Moderate (3): Removes the existing `HVDCDCControlConstraint` export.
`src/operation/template_validation.jl`	Reorganizes outage validation.	—
`src/operation/decision_model.jl`	Changes system output persistence.	Moderate (3): Comments out the `PSY.to_file` persistence call.
`src/hybrid_system_models/hybrid_systems.jl`	Updates hybrid reserve keys.	—
`src/energy_storage_models/storage_models.jl`	Updates storage reserve keys.	—
`src/core/variables.jl`	Adds G-1 variables.	—
`src/core/formulations.jl`	Adds security-constrained reserve formulations.	Nit (1): Documentation inaccurately describes service attachment validation.
`src/core/expressions.jl`	Adds post-contingency expressions.	—
`src/core/constraints.jl`	Adds G-1 constraints.	Nit (1): Exported constraint retains an incomplete docstring.
`src/common_models/converter_control.jl`	Updates EnumX type signatures.	—
`src/common_models/add_to_expression.jl`	Updates reserve expression keys.	—
`Project.toml`	Updates package sources and dependencies.	Critical (3): Contributor-specific absolute path prevents clean checkout and CI instantiation.
`ext/PowerFlowsExt/pf_headroom.jl`	Updates EnumX bus typing.	—
`.claude/pom_port_plan.md`	Removes the porting plan.	—

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

 export RealizedShiftedLoadMinimumBoundConstraint
 export NonAnticipativityConstraint
-export HVDCDCControlConstraint
+export PostContingencyGenerationBalanceConstraint


acostarelli · 2026-09-23T19:27:38Z

+flows are built only on modeled components, so monitored components must be a subset of the
+modeled ones.
+"""
+function _check_security_constrained_reserve_monitors(


This feels like this should be in template validation.

Also I'm not sure if we need a whole check for this. We can either error or warn when building the deviation variables.

acostarelli · 2026-09-23T19:28:54Z

+end
+
+# Outaged generators whose power the model can remove; the rest are skipped with a warning.
+function _outaged_generators(


Why is this helper per one outage, and the other one is per all the outages?

acostarelli · 2026-09-23T19:29:04Z

-            )
+    outage::PSY.Outage,
+)
+    outaged = _PER_TYPE()


I'm considering dropping this const alias.

acostarelli · 2026-09-23T19:29:36Z

+    return monitored_components
+end
+
+# Parallel circuits share one reduced entry, so each entry is constrained once.


Unnecessary comment

acostarelli · 2026-09-23T19:30:34Z

 end

+# Every outage gets a balance row per network region. Modeled interchanges carry a deviation
+# variable per outage, balanced across areas; monitored interchanges (a subset of the modeled


I think the subset comment is unnecessary.

acostarelli · 2026-09-23T21:06:41Z

+        )
+        for devices in values(contributing_devices)
+            # Ramp limits bind spinning reserves only.
+            _is_ramp_formulation(F) && R <: PSY.Reserve &&


Make helper

acostarelli · 2026-09-23T21:07:11Z

+    ),
+)
+
+_valid_component_type(::PSY.ACTransmission, ::NetworkModel{<:AbstractPTDFNetworkModel}) =


Maybe better name like _valid_monitored_component

acostarelli · 2026-09-23T21:13:22Z

+    ::NetworkModel{AreaBalanceNetworkModel},
+)
+    if !has_container_key(container, FlowActivePowerVariable, PSY.AreaInterchange)
+        @warn "An AreaBalanceNetworkModel with security-constrained reserves needs PSY.AreaInterchange(s) and DeviceModel{PSY.AreaInterchange} for reserve deployment to cross area boundaries. Otherwise, each area must cover its own outages." _group =


Don't love how this is worded

acostarelli · 2026-09-23T21:15:40Z

 struct BThetaBranchFlow <: ExpressionType end
-struct PostContingencyNodalActivePowerDeployment <: PostContingencyExpressions end
+
+"""


I think we can combine this with the area one and just do PostContingencyLocationalDeployment

acostarelli · 2026-09-23T21:18:26Z

+end
+
+_post_contingency_flow_expression(::NetworkModel{<:AbstractPTDFNetworkModel}) =
+    PostContingencyBranchFlow


Same thought here, we can combine these and do PostContingencyBranchFlow or some more generic name than Branch. And both PTDF and Area will use the same.

acostarelli · 2026-09-24T16:43:18Z

+    return outaged
+end
+
+function _monitored_components(


Still not checking for filtered?

jd-lara · 2026-09-25T19:58:32Z

@acostarelli we should close this and reopen with just the G-1 code

Anthony Costarelli added 20 commits September 17, 2026 17:36

refactor services constructor

a0d8505

port DCP constraints; reorganize validation

17f55ff

found elegant solution to type stability of outaged devices

dc10a33

copperplate done

9e8dbdd

partially done ptdf need to rebase

ff8844c

ptdf flow tentativley implemented

66ab512

much of this needs to happen aggregated across service models

b54cd31

restored ptdf

a02a27d

added areas and validation-sorta

5bd5c42

test file updated; code compiles

ff61f27

more bug fixes

93f5e3b

claude bug fixes and test rewrites

f8e0a78

clean up claude code; fix locational power; remaining: that weird con…

5fa1af0

…straint and slacks on flow

some bug fixes + claude fix reserve constraint

e418005

formatting

524d3ed

claude fixing some tests; not a fan of the MOI checks, and then these…

12d513d

… slacks keys need to be reconsidered I think

reorganize around ComponentPair-keyed reserve variables; update rest …

25f91d2

…of reserves code; enumx

pom breaking currently, going to pause and open pr

838bc48

formatting

1b4468c

claude fix bugs

fd0b6af

acostarelli requested a lite review from Copilot September 23, 2026 03:31

Copilot started reviewing on behalf of acostarelli September 23, 2026 03:31 View session

acostarelli mentioned this pull request Sep 23, 2026

Port G-1 reserves #320

Closed

Copilot AI reviewed Sep 23, 2026

View reviewed changes

acostarelli commented Sep 23, 2026

View reviewed changes

Anthony Costarelli added 2 commits September 23, 2026 15:24

claude address review comments

791a2df

sc test fixes

07d7ce4

acostarelli commented Sep 23, 2026

View reviewed changes

acostarelli commented Sep 24, 2026

View reviewed changes

Conversation

acostarelli commented Sep 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jd-lara commented Sep 25, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants