bug fixes - #291
Merged
Merged
bug fixes#291
Conversation
Member
|
@m-bossart can you rebase this branch on main? |
m-bossart
force-pushed
the
mb/more-pom-bugs
branch
from
September 10, 2026 17:18
f4d955d to
84d2b0a
Compare
luke-kiernan
approved these changes
Sep 11, 2026
jd-lara
reviewed
Sep 11, 2026
jd-lara
left a comment
jd-lara
left a comment
Member
There was a problem hiding this comment.
Yeah, we are aware of the mess introduced with Julia 1.13 that will have CI/CD broken for a minute
jd-lara
reviewed
Sep 11, 2026
| function _add_to_branch_map!( | ||
| branch_typed_dict::Dict{DataType, Vector{String}}, | ||
| reduction_entry::Union{PNM.BranchesParallel, PNM.BranchesSeries}, | ||
| reduction_entry::Union{PNM.AbstractBranchesParallel, PNM.BranchesSeries}, |
Member
There was a problem hiding this comment.
Don't we have an upper level abstract there? Union{Abstract, concrete} aren't great. Ok if not but if possible
jd-lara
reviewed
Sep 11, 2026
jd-lara
left a comment
jd-lara
left a comment
Member
There was a problem hiding this comment.
I wonder if we can remove some of the unions with abstracts
luke-kiernan
approved these changes
Sep 14, 2026
rodrigomha
added a commit
that referenced
this pull request
Sep 14, 2026
Brings #291: m-bossart's branch-constructor and expression fixes and the PNM abstract type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1: outage discovery ignores availability. When POM auto-discovers which components each Outage monitors, it checks that the component resolves against the system and that its type is modeled, but never
that it is available. An unavailable branch is excluded from the Ybus and therefore from the branch catalog, so the build dies.
Bug 2: mixed-type parallel groups bind the wrong method. POM's interface and inter-area paths dispatch on the reduction entry at each arc, with methods for a plain branch, BranchesParallel, and
BranchesSeries — but none for MixedBranchesParallel, the group PNM builds when parallel branches have different concrete types. Because every PNM reduction wrapper subtypes PSY.ACTransmission, the group
doesn't fail on dispatch; it silently binds the single-branch method, which asks it for a name field it does not have and throws a FieldError several frames deep.