Conversation
Performance ResultsPrecompile Time
Execution TimeCells show median (min–max) over 5 samples; delta compares medians.
|
luke-kiernan
left a comment
There was a problem hiding this comment.
I'll approve but I'd suggest adding a test case, or at least opening an issue to add one
There are tests in the PRs linked above that can be ported here |
I'll address the small fix and then port the test here before merging. |
m-bossart
left a comment
There was a problem hiding this comment.
@mcllerena can you port the tests from #362 also
Yes, just pushed on the last commit. |
jd-lara
left a comment
There was a problem hiding this comment.
This PR should be green in CI/CD to pass
When running the AC Power Flow on EI cases (2026/2027/2030/2035) for
SLLandSUMscenarios. The following error triggers for AC-VOLTAGE VSC controlThe zero-impedance reduction in PNM.jl was merging two distinct VSC terminal buses through an intermediate bus. PNM already supported irreducible buses, but the protection logic was checked against the original branch endpoints only. After an intermediate bus had already been merged, it was no longer recognized as belonging to a protected group and got reduced.
This PR ensures the VSC endpoint buses remain distinct through the zero-impedance reduction with the VSC control modes preserved so that PF.jl can map the converters to distinct reduced AC buses.