Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PSS/E cases with HVDC lines imported into PowerSystems with LCC and VSC impedances per-unitized twice.
psse.jlconverted these impedances to per-unit,dc_branch.jltagged the result as ohms ("ohm") or siemens ("S"), and the PowerSystems importer converted them again.LCC resistances and reactances came out too small by a factor of Z_base, and VSC
gwas off by the same kind of factor.Power flows on any PSS/E case with HVDC lines were wrong.
Changes
psse.jlkeepsRDC,RCR,XCR,RCI,XCI,XCAPR,XCAPIand the VSCRDCin ohms, which is the unit the OpenAPI writer expects.compounding_resistancewas already in ohms, so all LCC impedances now use the same unit.MDC=0) with a zero scheduled DC voltage (VSCHD) now parses without a warning, since the parser no longer converts to per-unit.An in-service line with
VSCHD=0still raises an error.dc_branch.jland PowerSystems need no change.Testing
They failed before this change.
PSY.from_file), every LCC and VSC impedance matches a hand calculation from the raw file ontwo-terminal-hvdc_test,vsc-hvdc_test,case16_all_componentsandcase25_v35_savnwb.Known remaining issue
For an out-of-service LCC line with
VSCHD=0, the PowerSystems importer still divides by zero and setsrtoInf.That already happened before this change, and it needs a fix in PowerSystems.
🤖 Generated with Claude Code